Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate formatter to AsyncDocumentFormattingService #391

Merged
merged 11 commits into from
Sep 17, 2024

Conversation

koxudaxi
Copy link
Owner

@koxudaxi koxudaxi commented Mar 1, 2024

No description provided.

Copy link

github-actions bot commented Mar 1, 2024

Qodana Community for JVM

28 new problems were found

Inspection name Severity Problems
Usage of API marked for removal 🔴 Failure 6
Unstable API Usage 🔴 Failure 2
Unstable API Usage 🔶 Warning 4
Incorrect string capitalization 🔶 Warning 3
Unused import directive 🔶 Warning 3
Unused symbol 🔶 Warning 3
Usage of redundant or deprecated syntax or deprecated symbols 🔶 Warning 1
Array property in data class ◽️ Notice 1
Const property naming convention ◽️ Notice 1
Class member can have 'private' visibility ◽️ Notice 1
Package name does not match containing directory ◽️ Notice 1
Private property naming convention ◽️ Notice 1
Regular expression can be simplified ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@MichaReiser
Copy link

Thanks that was quick. I think you missed committing the new RuffAsyncFormatter service

@koxudaxi
Copy link
Owner Author

koxudaxi commented Mar 1, 2024

@MichaReiser
You are right!! I forgot to add the file 😅
I pushed minimum Implementation.
The implementation needs to be optimized.

Copy link

github-actions bot commented Mar 27, 2024

Qodana Community for JVM

28 new problems were found

Inspection name Severity Problems
Usage of API marked for removal 🔴 Failure 6
Unused import directive 🔶 Warning 5
Unstable API Usage 🔶 Warning 4
Incorrect string capitalization 🔶 Warning 3
Unused symbol 🔶 Warning 3
Usage of redundant or deprecated syntax or deprecated symbols 🔶 Warning 1
Array property in data class ◽️ Notice 1
Const property naming convention ◽️ Notice 1
Class member can have 'private' visibility ◽️ Notice 1
Package name does not match containing directory ◽️ Notice 1
Private property naming convention ◽️ Notice 1
Regular expression can be simplified ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.2
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@koxudaxi koxudaxi marked this pull request as ready for review September 17, 2024 17:02
@koxudaxi koxudaxi merged commit 1676adc into main Sep 17, 2024
4 of 5 checks passed
@koxudaxi koxudaxi deleted the migrate_formatter_to_AsyncDocumentFormattingService branch September 17, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants