Remove autoscaling targets when min-scale is equal to max-scale, closes

#182
koyeb · Feb 5, 2024 · c332baa · c332baa
1 parent 6fc19c5
commit c332baa
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,3 +1,8 @@
+## v3.8.0 (unreleased)
+
+* `koyeb service update`: remove autoscaling targets when --min-scale is equal to --max-scale
+  - https://github.com/koyeb/koyeb-cli/issues/182
+
 ## v3.7.1
 
 * Add `koyeb db update <name> --instance-type <type>` to update the instance type of a database

diff --git a/pkg/koyeb/services.go b/pkg/koyeb/services.go
@@ -704,7 +704,7 @@ func parseScalings(flags *pflag.FlagSet, currentScalings []koyeb.DeploymentScali
 // because NewDeploymentScalingTarget{AverageCPU,AverageMem,RequestsPerSecond}
 // do not implement a common interface.
 func setScalingsTargets(flags *pflag.FlagSet, scaling *koyeb.DeploymentScaling) {
-	if scaling.Targets == nil {
+	if scaling.Targets == nil || scaling.GetMin() == scaling.GetMax() {
 		scaling.Targets = []koyeb.DeploymentScalingTarget{}
 	}