Make sure that we always fetch latest commit sha #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelbeza
commented
Jan 15, 2024
pkg/koyeb/utils.go
Outdated
| @@ -0,0 +1,9 @@ | |||
| package koyeb | |||
There was a problem hiding this comment.
normally would call utils but just following convention of one large package
brmzkw
reviewed
Jan 15, 2024
pkg/koyeb/services.go
Outdated
| @@ -165,6 +165,11 @@ $> koyeb service update myapp/myservice --env PORT=8001 --env '!DEBUG'`, | |||
| updateDef = latestDeploy.GetDeployments()[0].Definition | |||
| } | |||
|
|
|||
| // zero the sha to make sure that the latest sha is fetched | |||
| if updateDef.Git != nil { | |||
| updateDef.Git.Sha = AsPointer("") | |||
There was a problem hiding this comment.
instead of the utils package, can you use koyeb.PtrString?
pawelbeza
force-pushed
the
pawel/always-fetch-latest-commit
branch
from
f1a6fe3 to
29fe8db
Compare
When we update the service definition we don't want to copy sha from the previous deployment but rather fetch the latest one. For that we need to zero git sha in deployment definiton which will trigger fetching latest change.
pawelbeza
force-pushed
the
pawel/always-fetch-latest-commit
branch
from
29fe8db to
927b475
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we update the service definition we don't want to copy sha from the previous deployment but rather fetch the latest one. For that we need to zero git sha in deployment definiton which will trigger fetching latest change.