Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple svgs show same QRCode #210

Closed
Psycarlo opened this issue Jul 11, 2024 · 5 comments
Closed

Multiple svgs show same QRCode #210

Psycarlo opened this issue Jul 11, 2024 · 5 comments
Labels
reviewed Temporary label to review all open and closed PR

Comments

@Psycarlo
Copy link

Reproduce steps:

  1. Add multiple qrcodes in one page.
  2. They should be of type "svg"

Every QRCode will look the same.
@Psycarlo
Copy link
Author

Clip-path uses the same url id when multiple svgs are present.

@Psycarlo
Copy link
Author

As per: https://stackoverflow.com/questions/15911717/clippath-in-multiple-svg-tags
We should allow the user to pass an id or this be automatically generated so multiple qrcodes on the same page are correctly rendered.

@broekema41
Copy link

Just confirming here that in the browser when there are multiple qr codes on a page the page the content the same code. This is only for the svg implementation the canvas one does not have this issue.

@Nayanchandrakar
Copy link

i am using this package in my project is there way currently to add it

kmoschcau added a commit to blecon-GmbH/qr-code-styling that referenced this issue Sep 17, 2024
@kmoschcau
feat: add configurable HTML-ID prefix for SVG codes
5e1ad7b 
This adds an option for callers to provide an HTML-ID prefix for SVG
QR-codes, in order to make them unique and enable using this library for
multiple QR-codes on a single page.

Further it adds a .node-version file which can be used by nodenv or just
manual node version selection, to specify a node version that is able to
install, build and test this code base without adding any changes.

Closes kozakdenys#210.
@kmoschcau kmoschcau mentioned this issue Sep 17, 2024
Closed
@kozakdenys kozakdenys mentioned this issue Oct 14, 2024
Merged
@kozakdenys
Copy link
Owner

Hi @Psycarlo @broekema41 @Nayanchandrakar. This issue should be fixed in version v1.7.1 and above.
Please reopen the issue if something doesn't work for you.

@kozakdenys kozakdenys added the reviewed Temporary label to review all open and closed PR label Oct 15, 2024
This was referenced Oct 21, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
reviewed Temporary label to review all open and closed PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add configurable HTML-ID prefix for SVG codes blecon-GmbH/qr-code-styling
4 participants
@broekema41 @kozakdenys @Psycarlo @Nayanchandrakar