Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Wrapper optimizers #332

Merged
merged 10 commits into from
Jan 25, 2025
Merged

[Fix] Wrapper optimizers #332

merged 10 commits into from
Jan 25, 2025

Conversation

kozistr
Copy link
Owner

@kozistr kozistr commented Jan 25, 2025

Problem (Why?)

related to #329

Solution (What/How?)

  • add state_dict, and load_state_dict methods to TRAC, and OrthoGrad optimizers

Other changes (bug fixes, small refactors)

N/A

Notes

N/A

@kozistr kozistr added bug Something isn't working enhancement New feature or request refactoring Refactoring labels Jan 25, 2025
@kozistr kozistr self-assigned this Jan 25, 2025
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7a9377a) to head (dae7169).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #332   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          108       108           
  Lines         8494      8509   +15     
=========================================
+ Hits          8494      8509   +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 25, 2025
@kozistr kozistr merged commit 81acb1e into main Jan 25, 2025
4 checks passed
@kozistr kozistr deleted the fix/wrapper-optimizer branch January 25, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request refactoring Refactoring size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant