Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOP operations calculate the fits wrong! #44

Closed
kpagacz opened this issue Feb 12, 2025 · 0 comments · Fixed by #47
Closed

BOP operations calculate the fits wrong! #44

kpagacz opened this issue Feb 12, 2025 · 0 comments · Fixed by #47

Comments

@kpagacz
Copy link
Owner

kpagacz commented Feb 12, 2025

No description provided.

kpagacz added a commit that referenced this issue Feb 14, 2025
* Bloated the code a little bit, but I finally got the binary operations
down RIGHT.
* Look at the new integration tests - PURE CINEMA.
* Cleaned up some of the weird groupping in different places,
I think I also finally understood when to group and when not to group.

Closes #44
@kpagacz kpagacz linked a pull request Feb 14, 2025 that will close this issue
kpagacz added a commit that referenced this issue Feb 14, 2025
fix: finally got the bops right

* Bloated the code a little bit, but I finally got the binary operations
down RIGHT.
* Look at the new integration tests - PURE CINEMA.
* Cleaned up some of the weird groupping in different places,
I think I also finally understood when to group and when not to group.
* Fixed some of the comment stuff as well. Some comment hoisting happened.
* Also introduced "hardbreak" as a doc, which I think will help in general
and I will replace some of the logic with it.
* I should remove the stuff that is not necessary at this point - inline comment positions, etc.
These things should be covered by hard breaks.

Closes #44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant