Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hook to get the value #141

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

fum1h1to
Copy link
Contributor

gache has an expiredHook that allows users to get the key when the cache expires.
However, I would like to get the key and value when the cache expires.

In this PR, add an expiredHookWithValue to get the key and value when the cache expires.

@kpango
Copy link
Owner

kpango commented Oct 25, 2024

Delete interface has been changed, which is a breaking change, and in that case the Minor or Major needs to be released, so if you want to change it, just make the ExpiredHook default to passing Value as well, and don't add any functions.

@fum1h1to
Copy link
Contributor Author

Delete interface has been changed, which is a breaking change, and in that case the Minor or Major needs to be released, so if you want to change it, just make the ExpiredHook default to passing Value as well, and don't add any functions.

fixed: b877868

Copy link
Owner

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@kpango kpango merged commit e25d067 into kpango:main Oct 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants