[patch] optimize foreach goroutines #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
=========================================
Coverage ? 10.32%
=========================================
Files ? 1
Lines ? 155
Branches ? 0
=========================================
Hits ? 16
Misses ? 139
Partials ? 0
Continue to review full report at Codecov.
|
golangcibot
reviewed
Feb 4, 2019
gache.go
Outdated
| wg.Add(1) | ||
| go func(c context.Context, idx int) { | ||
| defer wg.Done() | ||
| g.shards[i].data.Range(func(k, v interface{}) bool { |
There was a problem hiding this comment.
loop variable i captured by func literal (from govet)
kpango
force-pushed
the
feature-optimize-foreach-goroutine
branch
2 times, most recently
from
80e9ede to
35e127f
Compare
kpango
force-pushed
the
feature-optimize-foreach-goroutine
branch
from
35e127f to
4f9b391
Compare
kpango
force-pushed
the
feature-optimize-foreach-goroutine
branch
from
258cc58 to
5e2977f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.