Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for roundingmoderte capability #563

Merged
merged 4 commits into from
Jul 9, 2023
Merged

add support for roundingmoderte capability #563

merged 4 commits into from
Jul 9, 2023

Conversation

rjodinchr
Copy link
Contributor

No description provided.

@rjodinchr rjodinchr mentioned this pull request Jun 28, 2023
Merged
@rjodinchr rjodinchr marked this pull request as draft June 28, 2023 15:11
@rjodinchr
Copy link
Contributor Author

This PR depends on google/clspv#1146

@rjodinchr
Copy link
Contributor Author

In fact, as swiftshader does not support RoundingModeRTE, this PR could pass the CI it seems.
But it would break all platforms supporting RoundingModeRTE with an unknown option when calling clspv.
Let's wait for clspv PR to land ^^

@rjodinchr rjodinchr marked this pull request as ready for review July 1, 2023 06:53
kpet
kpet requested changes Jul 1, 2023
View reviewed changes
Copy link
Owner

@kpet kpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call on making this optional. Requiring it would have prevented clvk from running on a number of older Vulkan implementations.

src/device.cpp Outdated Show resolved Hide resolved
@rjodinchr rjodinchr requested a review from kpet July 2, 2023 15:48
@kpet
Copy link
Owner

kpet commented Jul 3, 2023

I'm seeing the following in conformance runs (along with many failures):

error: Cannot set RoundingModeRTE for fp64 if fp64 is not supported

@rjodinchr
Copy link
Contributor Author

It is quite weird that shaderRoundingModeRTEFloat64 could be set without shaderFloat64...

@kpet
Copy link
Owner

kpet commented Jul 3, 2023 •
edited
Loading

I think it's because we don't enable fp64 support in clspv based on shaderFloat64 since clspv doesn't have full support for doubles.

EDIT: Hmm, apparently not. This is weird. I'll run the CTS against your latest and merge it assuming no regressions.

@kpet kpet merged commit 38c9586 into kpet:main Jul 9, 2023
9 checks passed
@rjodinchr rjodinchr mentioned this pull request Jul 9, 2023
Closed
@rjodinchr rjodinchr deleted the pr/rte branch July 10, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpet kpet kpet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjodinchr @kpet