Assert when a batchable command in built into a batch after being built as standalone #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt as standalone Catching the opposite would require adding state to cvk_command_batchable but it's a much harder mistake to make so probably not worth it. Change-Id: I2a010f1e157a4713ef6da907c9b45f4ff2defaf2 Signed-off-by: Kévin Petit <kpet@free.fr>
Change-Id: I0a59463a38f6b4c6a0ad7e22f48ec3d8a9798565
rjodinchr
approved these changes
Jul 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catching the opposite would require adding state to cvk_command_batchable but it's a much harder mistake to make so probably not worth it.
Change-Id: I2a010f1e157a4713ef6da907c9b45f4ff2defaf2