Set CL_DEVICE_IMAGE_PITCH_ALIGNMENT to 1 when images are supported. #572
Conversation
The spec says that it should be 0 if images are not supported. Otherwise it should be a power of 2. 0 isn't a power of 2 and causes problems with tests which expect to be able to use CL_DEVICE_IMAGE_PITCH_ALIGNMENT to calculate memory allocation sizes etc.
There was a problem hiding this comment.
Thanks for the contribution! Assuming I'm reading the specification correctly, this change looks incorrect. The spec states:
The value returned must be a power of 2.
Support for 2D images created from a buffer is required for an OpenCL 2.0, 2.1, or 2.2 device if CL_DEVICE_IMAGE_SUPPORT is CL_TRUE.
This value must be 0 for devices that do not support 2D images created from a buffer.
clvk is an OpenCL 3.0 implementation and does not currently support creating 2D images from buffers (see #43). As far as I can tell, reporting 0 is the correct behaviour.
Furthermore, this change fails the consistency_2d_image_from_buffer CTS test.
My guess would be that the failing application is making incorrect assumptions and not checking for support before using the value returned by CL_DEVICE_IMAGE_PITCH_ALIGNMENT.
|
Thanks for reviewing this. You are right, it does look like an app issue. I'll close this PR. |
The spec says that it should be 0 if images are not supported. Otherwise it should be a power of 2. 0 isn't a power of 2 and causes problems with tests which expect to be able to use CL_DEVICE_IMAGE_PITCH_ALIGNMENT to calculate memory allocation sizes etc.