add option to force to build in a separate thread #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm experiencing issues with clang starting to segfault in the frontend. Building in a separate thread fixes the issue. It feels like a stack corruption, but I did not figure out exactly where it is coming from. I am not able to have a simple reproducer that I can share yet. |
|
This is not needed anymore in ChromeOS. It seems that clang has been fixed. |
Also name the build thread only if built in a separate thread.
rjodinchr
force-pushed
the
pr/build-in-thread
branch
from
3bf08b7
to
0e10d3f
Compare
kpet
approved these changes
Aug 29, 2024
kpet
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also name the build thread only if built in a separate thread.