rollback return of NewRegistry to copy, not pointer

kpetremann · Dec 19, 2023 · 1922c20 · 1922c20
1 parent 2226378
commit 1922c20
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/internal/metrics/metrics.go b/internal/metrics/metrics.go
@@ -80,7 +80,7 @@ func ExposeMetrics(ctx context.Context, eventChan <-chan event.SaltEvent, watchC
 				return
 			}
 
-			eventToMetrics(event, registry)
+			eventToMetrics(event, &registry)
 		}
 	}
 }
diff --git a/internal/metrics/registry.go b/internal/metrics/registry.go
@@ -27,7 +27,7 @@ type Registry struct {
 	minionsTotal       *prometheus.GaugeVec
 }
 
-func NewRegistry(config Config) *Registry {
+func NewRegistry(config Config) Registry {
 	functionResponsesTotalLabels := []string{"function", "state", "success"}
 	if config.SaltFunctionResponsesTotal.AddMinionLabel {
 		functionResponsesTotalLabels = append([]string{"minion"}, functionResponsesTotalLabels...)
@@ -38,7 +38,7 @@ func NewRegistry(config Config) *Registry {
 		scheduledJobReturnTotalLabels = append([]string{"minion"}, scheduledJobReturnTotalLabels...)
 	}
 
-	return &Registry{
+	return Registry{
 		config: config,
 
 		observedMinions: 0,
-Original file line number
+Diff line change
@@ Expand Up @@
     				return
     			}
-    			eventToMetrics(event, registry)
+    			eventToMetrics(event, &registry)
     		}
     	}
     }