fix!: salt_responses_total was not including scheduled job return

kpetremann · Jul 8, 2023 · da87638 · da87638
1 parent 111de67
commit da87638
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/internal/metrics/metrics.go b/internal/metrics/metrics.go
@@ -40,10 +40,10 @@ func eventToMetrics(event event.SaltEvent, r Registry) {
 			}
 			r.IncreaseScheduledJobReturnTotal(event.Data.Fun, state, event.Data.Id, success)
 		} else {
-			r.IncreaseResponseTotal(event.Data.Id, success) // TODO: move outside the if?
 			r.IncreaseFunctionResponsesTotal(event.Data.Fun, state, event.Data.Id, success)
 		}
 
+		r.IncreaseResponseTotal(event.Data.Id, success)
 		r.SetFunctionStatus(event.Data.Id, event.Data.Fun, state, success)
 	}
 }

diff --git a/internal/metrics/registry.go b/internal/metrics/registry.go
@@ -70,7 +70,7 @@ func NewRegistry(config Config) Registry {
 		responseTotal: promauto.NewCounterVec(
 			prometheus.CounterOpts{
 				Name: "salt_responses_total",
-				Help: "Total number of response job processed",
+				Help: "Total number of response job processed, including scheduled job",
 			},
 			[]string{"minion", "success"},
 		),