Refacto configuration #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this separation, pretty logging cannot be set before knowing the log level. Hence it ended up with json logs if there was an issue during config read.
The goal is to be able to configure the exporter from both flags and YAML config file. Ultimately we will be able to load configuration from varenv too, which is useful when using docker-compose. Important note: To avoid breaking change on the CLI, we keep golang flags. We do not migrate to pflag like viper users usually do. This is because golang flags authorize long name with one or two dashes: -port 8080 or --port 8080 Pflag follows UNIX convention, so it does not authorize single dash for long names. The benefit is that pflag supports shortname concatenation: -a -b -c ==> -abc.
Makes more sense to move these as filters in the metrics configuration.
Closer to usage.
Closer to usage.
More structured main to respect one function = one role.
kpetremann
force-pushed
the
refacto_configuration
branch
from
6ee7e34 to
c29c864
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrate to viper configuration