Configurable metrics #35

kpetremann · 2023-06-30T16:18:31Z

each metrics can now be enabled/disabled.

Some can be filtered or customized.

Example of configuration:

metrics:
  global:
    filters:
      ignore-test: false
      ignore-mock: false

  salt_new_job_total:
    enabled: true

  salt_expected_responses_total:
    enabled: true

  salt_function_responses_total:
    enabled: true
    add-minion-label: false  # not recommended in production

  salt_scheduled_job_return_total:
    enabled: true
    add-minion-label: false  # not recommended in production

  salt_responses_total:
    enabled: true

  salt_function_status:
    enabled: true
    filters:
      functions:
        - "state.highstate"
      states:
        - "highstate"

Note: It deprecated -health-minions, health-functions-filter and health-states-filter flags. They should be replaced by configuring metrics in the config.yml file.

Implements: #26

The goal is to be able to enable or disable any metric we want independently. Some metrics can be disabled for cardinality scaling.

This is now replaced by enable/disable metric feature.

Add-minions permits to add the minion flag in some metrics. The goal is to provide even more data for people who needs them, especially for troubleshoot or small infra. This is not recommended for production with large scale.

kpetremann added 9 commits June 28, 2023 22:35

feat: be able to enable/disable metrics

3f67266

The goal is to be able to enable or disable any metric we want independently. Some metrics can be disabled for cardinality scaling.

feat: deprecate health-* flags

bdf8e9b

This is now replaced by enable/disable metric feature.

feat: introduce add-minions configuration for some metrics

f2f7031

Add-minions permits to add the minion flag in some metrics. The goal is to provide even more data for people who needs them, especially for troubleshoot or small infra. This is not recommended for production with large scale.

fix: wrong default values for metrics.*.enabled

cd403d2

fix: remove write config used for debug

3563d9f

fix: swapped 'add-minion-label' and 'salt_scheduled_job_return_total'

3077fdb

fix: config not loading properly

86a7c3f

fix: deprecated flags were incorrect

55ac470

docs: update README

b9310d4

kpetremann merged commit 351ed1c into main Jun 30, 2023

kpetremann deleted the configurable_metrics branch June 30, 2023 16:21

kpetremann restored the configurable_metrics branch June 30, 2023 16:21

kpetremann deleted the configurable_metrics branch June 30, 2023 16:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Configurable metrics #35

Configurable metrics #35

kpetremann commented Jun 30, 2023 •

edited

Loading

Configurable metrics #35

Configurable metrics #35

Conversation

kpetremann commented Jun 30, 2023 • edited Loading

kpetremann commented Jun 30, 2023 •

edited

Loading