Fix parsing on older versions of salt #69
Conversation
On older versions of salt, the message body is already a string which causes the .([]byte) type assertion to fail. This catches that failure than then tries an .(string) assertion to handle both cases.
| if raw, ok := message["body"].([]byte); ok { | ||
| body = string(raw) | ||
| } else { | ||
| body = message["body"].(string) |
There was a problem hiding this comment.
could you please add a small comment to explain the reason of doing this fallback
| body := string(message["body"].([]byte)) | ||
| var body string | ||
|
|
||
| if raw, ok := message["body"].([]byte); ok { |
There was a problem hiding this comment.
opt/nit: using a type switch may be cleaner
|
hello, Thanks for the PR :) I would have preferred to reproduce the issue first with Salt old version. |
Of course!
I can reliably reproduce here as we have an old production server that we need to migrate from, but in the mean time I'm trying to add some monitoring before we do anything which led to me finding the issue. |
On older versions of salt, the message body is already a string which causes the .([]byte) type assertion to fail. This catches that failure than then tries an .(string) assertion to handle both cases.
Fixes #68