Log and continue on repo error during lists (#4038)

Signed-off-by: John Belamaric <jbelamaric@google.com>
kptdev · Sep 13, 2023 · bbe8ea5 · bbe8ea5
1 parent b18e2c8
commit bbe8ea5
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/porch/pkg/registry/porch/packagecommon.go b/porch/pkg/registry/porch/packagecommon.go
@@ -72,7 +72,8 @@ func (r *packageCommon) listPackageRevisions(ctx context.Context, filter package
 
 		revisions, err := r.cad.ListPackageRevisions(ctx, repositoryObj, filter.ListPackageRevisionFilter)
 		if err != nil {
-			return err
+			klog.Warningf("error listing package revisions from repository %s/%s: %s", repositoryObj.GetNamespace(), repositoryObj.GetName(), err)
+			continue
 		}
 		for _, rev := range revisions {
 			apiPkgRev, err := rev.GetPackageRevision(ctx)
@@ -117,7 +118,8 @@ func (r *packageCommon) listPackages(ctx context.Context, filter packageFilter,
 
 		revisions, err := r.cad.ListPackages(ctx, repositoryObj, filter.ListPackageFilter)
 		if err != nil {
-			return err
+			klog.Warningf("error listing packages from repository %s/%s: %s", repositoryObj.GetNamespace(), repositoryObj.GetName(), err)
+			continue
 		}
 		for _, rev := range revisions {
 			if err := callback(rev); err != nil {