Skip to content

Commit

Permalink
Migrate dockerfile to release directory (#1566)
Browse files Browse the repository at this point in the history
* Migrate dockerfile to release directory
* Update releasing docs
  • Loading branch information
runewake2 authored Mar 18, 2021
1 parent f2b3b6d commit f56f41f
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 3 deletions.
5 changes: 4 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,10 @@ vet:
go vet ./...

docker:
docker build .
docker build -f release/Dockerfile .

docker-gcloud:
docker build -f release/gcloud/Dockerfile .

lintdocs:
(cd site && npm run lint-fix)
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion release/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ To cut a new kpt release perform the following:
- Within kustomize: [cmd/config](https://github.com/kubernetes-sigs/kustomize/blob/master/releasing)
- Update `go.mod` file with correct versions of `cli-utils`, `kyaml`, and `cmd/config`
- Update the pinned base image versions in the kpt Dockerfiles
([Dockerfile](./Dockerfile) and [release/gcloud/Dockerfile](./release/gcloud/Dockerfile))
([release/Dockerfile](./Dockerfile) and [release/gcloud/Dockerfile](./gcloud/Dockerfile))
- Run `make all` (which should update `go.sum` and run `go mod tidy`)
- Create a `kpt` PR with previous `go.mod` and `go.sum` changes, and submit. [Example PR](https://github.com/GoogleContainerTools/kpt/pull/594)
- Fetch the latest master changes to a clean branch
Expand Down
2 changes: 1 addition & 1 deletion release/tag/cloudbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ steps:
## kpt image
- name: 'gcr.io/cloud-builders/docker'
dir: 'kpt'
args: [ 'build', '-t', 'gcr.io/$PROJECT_ID/kpt:${TAG_NAME}', '.', '--build-arg', 'KPT_VERSION=${_VERSION}']
args: [ 'build', '-t', 'gcr.io/$PROJECT_ID/kpt:${TAG_NAME}', '-f', 'release/Dockerfile', '.', '--build-arg', 'KPT_VERSION=${_VERSION}']

- name: 'gcr.io/cloud-builders/docker'
dir: 'kpt'
Expand Down

0 comments on commit f56f41f

Please sign in to comment.