Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add e2e test for kpt live apply #1315

Merged
merged 2 commits into from
Jan 13, 2021
Merged

add e2e test for kpt live apply #1315

merged 2 commits into from
Jan 13, 2021

Conversation

Liujingfang1
Copy link
Contributor

The added test covers the following flow:

  • kpt live apply with a previous version of kpt
  • kpt live preview with built version of kpt for the same package
  • kpt live apply with built version of kpt for the same package.

/assign @mortent @seans3

@Liujingfang1
Copy link
Contributor Author

This one should be merged after #1307

@Liujingfang1 Liujingfang1 changed the title WIP: add e2e test for kpt live apply add e2e test for kpt live apply Jan 11, 2021
Copy link
Contributor

@mortent mortent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this test be better in cli-utils? It doesn't seem like this is something that is actually specific to kpt and it would be easier to set up the correct scenarios using the ginkgo tests in cli-utils.

e2e/live/end-to-end-test.sh Show resolved Hide resolved
@seans3 seans3 merged commit e3cee45 into kptdev:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants