Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update functions for wrapping an inventory ResourceGroup #1391

Merged
merged 1 commit into from
Jan 27, 2021
Merged

update functions for wrapping an inventory ResourceGroup #1391

merged 1 commit into from
Jan 27, 2021

Conversation

Liujingfang1
Copy link
Contributor

Replace the existing function

func WrapInventoryInfoObj(obj *unstructured.Unstructured) inventory.InventoryInfo

by

func WrapInventoryResourceGroup(obj *unstructured.Unstructured) *InventoryResourceGroup

The latter one can cover the use case of the former one. The latter one also helps simplify the integration with ConfigSync.

@Liujingfang1
Copy link
Contributor Author

/assign @seans3 @mortent

seans3
seans3 approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@seans3 seans3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@seans3 seans3 merged commit 23b736d into kptdev:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seans3 seans3 seans3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Liujingfang1 @seans3