-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kpt + Gcloud Image Definition #1553
Conversation
…into add-kpt-gcloud
In the PR description, can you specify the size of the two container images? |
@@ -0,0 +1,34 @@ | |||
# Copyright 2019 Google LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, the existing top-level Dockerfile should be moved to release directory as well. This can be a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. Will open that PR after this is merged to avoid conflicts with the merge/squash of this change.
release/gcloud/Dockerfile
Outdated
COPY . . | ||
RUN go build -v -o /usr/local/bin/kpt -ldflags="-s -w -X github.com/GoogleContainerTools/kpt/run.version=$KPT_VERSION" ./ | ||
|
||
FROM gcr.io/google.com/cloudsdktool/cloud-sdk:alpine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably use a pinned version instead. We don't want to have this change without our explicit consent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pinned this to 332.0.0-alpine
and updated our releasing steps to include updates to the base image versions prior to release.
- Update releasing instructions.
See: #1506
This introduces a new container image that includes
gcloud
alongside other programs configured withkpt
. The image will be released askpt-gcloud
into the same container registry as the kpt container (kpt-dev
). The image is based off of gcr.io/google.com/cloudsdktool/cloud-sdk:alpineThis image is significantly larger than the
kpt
image already published at gcr.io/kpt-dev/kpt but smaller than the larger general purposecloud-sdk
images that are available withkpt
.This PR also updates the kpt releasing README with steps that will allow you to run and validate Cloud Build releases of
kpt
against your local fork.Hardcoded github owner values have been removed from the kpt Goreleaser config to prevent publishing new releases to the
GoogleContainerTools/kpt
repo unintentionally. (note: this is still possible with wrong parameters and notes have been included to prevent this as best as possible)