Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for nonexistent pkg/kptfile. #1818

Merged
merged 1 commit into from
May 18, 2021
Merged

Conversation

etefera
Copy link
Contributor

@etefera etefera commented Apr 26, 2021

@etefera etefera requested a review from mortent April 26, 2021 16:05
@@ -33,7 +33,6 @@ func TestMain(m *testing.M) {
func TestCmdInvalidDiffType(t *testing.T) {
runner := cmddiff.NewRunner(fake.CtxWithNilPrinter(), "")
runner.C.SetArgs([]string{"--diff-type", "invalid"})
runner.C.SilenceErrors = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary but the silencing of the errors didn't affect the tests at all. Can undo if we prefer to keep that true.

@etefera etefera requested a review from mortent April 27, 2021 19:02
@etefera etefera merged commit d635439 into kptdev:next May 18, 2021
@etefera etefera deleted the no-pkg-kptfile branch May 18, 2021 07:52
frankfarzan pushed a commit to frankfarzan/kpt that referenced this pull request Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants