Add additional tests for kpt pkg update
#1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortent
changed the title
kpt pkg update
| @@ -815,6 +815,125 @@ func TestCommand_Run_failInvalidRef(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestCommand_Run_manualChange(t *testing.T) { | |||
There was a problem hiding this comment.
What if user changes Kptfile and also triggers cli command with different version ? Cli command takes precedence ?
There was a problem hiding this comment.
Yeah, the information provided through flags will be written to the Kptfile and then we go through the update process same as if it was updated manually.
phanimarupaka
approved these changes
May 4, 2021
frankfarzan
pushed a commit
to frankfarzan/kpt
that referenced
this pull request
Jun 3, 2021
* Test for manual update of the upstream section in Kptfile * Test for symlinks in upstream package during updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two additional tests:
Upstreamsection of the Kptfile manually and then use thekpt pkg updatecommand to actually update the package.kpt pkg get.