Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extra new line before error messages #1875

Merged
merged 1 commit into from
May 3, 2021

Conversation

Shell32-Natsu
Copy link
Contributor

The diff format is updated according to #1813

@Shell32-Natsu Shell32-Natsu added this to In Review in kpt kanban board via automation May 3, 2021
@Shell32-Natsu Shell32-Natsu changed the title remove extra new lines before error messages remove extra new line before error messages May 3, 2021
@@ -1,15 +1,14 @@
diff --git a/resources.yaml b/resources.yaml
index 7a494c9..c77c357 100644
index 7a494c9..a9dd224 100644
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? There doesn't seem to be anything in the rest of the PR that would change the format of the output.

Copy link
Contributor Author

@Shell32-Natsu Shell32-Natsu May 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the output format is changed in #1813

@Shell32-Natsu Shell32-Natsu merged commit 690249b into kptdev:next May 3, 2021
kpt kanban board automation moved this from In Review to Done May 3, 2021
@Shell32-Natsu Shell32-Natsu deleted the render-error-line branch May 3, 2021 18:58
frankfarzan pushed a commit to frankfarzan/kpt that referenced this pull request Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants