Extract container runtime & fn error resolver #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droot
approved these changes
May 3, 2021
frankfarzan
pushed a commit
to frankfarzan/kpt
that referenced
this pull request
Jun 3, 2021
* move fn to separate resolver * extract container runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract container runtime to a separate package from
cmdrender. This can make the dependency fromfn evalless ambiguous.fn evalwill share the representation layer withfn renderand the representation layer is in container runtime.Also move function error resolver to a separate file from
git.go.#1861