Unwrap kpt errors to prevent printing stacktrace #1880
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the printing behavior in
main.go
to unwrap any*error.Error
errors in the hierarchy to avoid printing the stacktrace. This essentially means we just take the error message from the first non-kpterror we find and print it to stderr. This resolves the issue where we show the stacktrace to users. The stacktrace can be included by either using the--stack-trace
flag or setting theCOBRA_STACK_TRACE_ON_ERRORS
env variable (we might want to revisit the name).With this change the output described in #1852 becomes will now be: