Update Nginx and Wordpress examples with protocol #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfarzan
reviewed
May 7, 2021
| configMap: | ||
| ms-image: mysql | ||
| ms-tag: 5.6 | ||
| - image: gcr.io/kpt-fn/apply-setters:v0.1 |
There was a problem hiding this comment.
is the being formatted by fn render? If so, awesome. If not, why not?
There was a problem hiding this comment.
It's being formatted by live init actually. Most of our commands don't write Kptfile back, live init does. The new yaml version adds indentation for list fields.
render doesn't format Kptfile. I think we should format the Kptfile too as part of render. Will have a separate PR for that.
There was a problem hiding this comment.
Yep, render should format everything. If you run render first, then live init should never change styling.
frankfarzan
approved these changes
May 7, 2021
frankfarzan
pushed a commit
to frankfarzan/kpt
that referenced
this pull request
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to update nginx and wordpress packages with protocol field so that server-side apply/preview works fine. This change also formats the Kptfile and adds info to all packages.