Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issues in version dropdown. #2077

Merged
merged 15 commits into from
May 21, 2021

Conversation

etefera
Copy link
Contributor

@etefera etefera commented May 21, 2021

Addresses #1662 for the new site.
Preview at https://kpt-dev-ee2a9--version-dropdown-98kk6v2g.web.app

@etefera etefera requested a review from frankfarzan as a code owner May 21, 2021 17:53
<button class="btn btn-primary dropdown-toggle" type="button" data-toggle="dropdown">v1.0.0-alpha.3
<span class="caret"></span></button>
<ol class="dropdown-menu">
<li><a href="/installation/">v1.0.0-alpha.3</a></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is OK for now but I think the full implementation of a version drop down would preserve the current page and maybe just modify the URL or something along those lines.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also maybe name it v1 beta1 or something more durable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do for now
We should decide on the branch/tag naming scheme for multiple versions of the documentation and tool we want to show publicly. That'll drive the dropdown entries in the future

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this. What's v1beta1? Please use the release semver.

Copy link
Contributor

@mikebz mikebz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving as a temporary solution.

@etefera etefera merged commit 53abff5 into kptdev:next May 21, 2021
@etefera etefera deleted the visualy-distinguish-docs branch May 21, 2021 19:51
frankfarzan pushed a commit to frankfarzan/kpt that referenced this pull request Jun 3, 2021
* Adds static version dropdown to site.

* Move cover page content into overview.

* Fix typo.

* Revert "Move cover page content into overview."

This reverts commit 05ba2b0.

* Add dropdown to sidebar instead.

* Change color of dropdown background.

* Fix cover page.

* Fix broken rendering.

* Fix broken issues.

* Add .firebase to git ignore.

* Link to old installation instead of home page.

* Remove border around dropdown.

* Link to installation for new page.

* Load old installation page in same frame.

* Rename current site documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants