Address issues in version dropdown. #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 05ba2b0.
mikebz
reviewed
May 21, 2021
site/static/js/plugins.js
Outdated
| <button class="btn btn-primary dropdown-toggle" type="button" data-toggle="dropdown">v1.0.0-alpha.3 | ||
| <span class="caret"></span></button> | ||
| <ol class="dropdown-menu"> | ||
| <li><a href="/installation/">v1.0.0-alpha.3</a></li> |
There was a problem hiding this comment.
this is OK for now but I think the full implementation of a version drop down would preserve the current page and maybe just modify the URL or something along those lines.
There was a problem hiding this comment.
I would also maybe name it v1 beta1 or something more durable.
There was a problem hiding this comment.
Will do for now
We should decide on the branch/tag naming scheme for multiple versions of the documentation and tool we want to show publicly. That'll drive the dropdown entries in the future
There was a problem hiding this comment.
I missed this. What's v1beta1? Please use the release semver.
mikebz
approved these changes
May 21, 2021
frankfarzan
approved these changes
May 21, 2021
frankfarzan
pushed a commit
to frankfarzan/kpt
that referenced
this pull request
Jun 3, 2021
* Adds static version dropdown to site. * Move cover page content into overview. * Fix typo. * Revert "Move cover page content into overview." This reverts commit 05ba2b0. * Add dropdown to sidebar instead. * Change color of dropdown background. * Fix cover page. * Fix broken rendering. * Fix broken issues. * Add .firebase to git ignore. * Link to old installation instead of home page. * Remove border around dropdown. * Link to installation for new page. * Load old installation page in same frame. * Rename current site documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1662 for the new site.
Preview at https://kpt-dev-ee2a9--version-dropdown-98kk6v2g.web.app