Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test for out-of-place sink #2081

Merged
merged 2 commits into from
May 24, 2021
Merged

add test for out-of-place sink #2081

merged 2 commits into from
May 24, 2021

Conversation

Shell32-Natsu
Copy link
Contributor

This test case works in this way:

  1. Create a temporary directory
  2. Run eval and sink to the temp dir
  3. Copy back the results

@Shell32-Natsu Shell32-Natsu merged commit 5aaa1a3 into kptdev:next May 24, 2021
@Shell32-Natsu Shell32-Natsu deleted the eval-out-of-place branch May 24, 2021 20:23
frankfarzan pushed a commit to frankfarzan/kpt that referenced this pull request Jun 3, 2021
@Shell32-Natsu @frankfarzan
add test for out-of-place sink (kptdev#2081)
52d381e 
* add test for out-of-place sink

* code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot droot approved these changes

@frankfarzan frankfarzan Awaiting requested review from frankfarzan

@natasha41575 natasha41575 Awaiting requested review from natasha41575

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shell32-Natsu @droot