Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for docker before running fn eval #2155

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

natasha41575
Copy link
Contributor

@natasha41575 natasha41575 commented Jun 3, 2021

fixes #2084

Adds a check for docker before running fn eval.

For example:

$ kpt fn eval simple-function --image gcr.io/kpt-fn/set-namespace:v0.1.3 -- namespace=staging

error: docker must be running to use this command
To install docker, follow the instructions at https://docs.docker.com/get-docker/.
$ kpt fn render basic-pipeline

Package "basic-pipeline":
error: docker must be running to use this command
To install docker, follow the instructions at https://docs.docker.com/get-docker/.

@Shell32-Natsu
Copy link
Contributor

Please add the example output in PR description.

@natasha41575
Copy link
Contributor Author

Please add the example output in PR description.

Done

internal/fnruntime/container.go Outdated Show resolved Hide resolved
internal/fnruntime/container.go Outdated Show resolved Hide resolved
internal/fnruntime/container.go Outdated Show resolved Hide resolved
@natasha41575 natasha41575 requested a review from droot June 4, 2021 22:53
@natasha41575 natasha41575 changed the title move docker command check to function runtime check for docker before running fn eval Jun 4, 2021
@natasha41575 natasha41575 merged commit 59e01de into kptdev:next Jun 7, 2021
@natasha41575 natasha41575 deleted the FnEvalCheckDocker branch June 7, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fn eval without docker running produces a misleading error
3 participants