Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update crd version for Kptfile to v1 #2248

Merged
merged 12 commits into from
Jun 17, 2021
Merged

Update crd version for Kptfile to v1 #2248

merged 12 commits into from
Jun 17, 2021

Conversation

Shell32-Natsu
Copy link
Contributor

Part of #2203

What this PR does:

  1. Updating the schema in the types.go & all references in tests (unit and end to end)/code
  2. Updating examples in the kpt repo
  3. Updating reference docs and book
  4. Updating the code that handles unrecognized versions of Kptfile, for example, if one uses kpt 1.0 and finds a package with alpha2 or previous versions

@Shell32-Natsu Shell32-Natsu changed the title Update crd version Update crd version for Kptfile to v1 Jun 15, 2021
frankfarzan
frankfarzan reviewed Jun 16, 2021
View reviewed changes
e2e/testdata/fn-render/basicpipeline-v1alpha1/.expected/config.yaml Show resolved Hide resolved
pkg/api/kptfile/v1/types.go Outdated Show resolved Hide resolved
pkg/api/kptfile/v1/types.go Outdated Show resolved Hide resolved
droot
droot requested changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@droot droot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we agree on removing the ignore field from the schema, other than that, it's looking good to me.

pkg/api/kptfile/v1/types.go Outdated Show resolved Hide resolved
frankfarzan
frankfarzan approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@frankfarzan frankfarzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please coordinate with @phanimarupaka on next release for migrating critical packages.

@droot
Copy link
Contributor

droot commented Jun 17, 2021

@Shell32-Natsu Can you double check if all the items listed in the original issue are addressed for all the CRDs.

mortent
mortent requested changes Jun 17, 2021
View reviewed changes
internal/pkg/pkg.go Outdated Show resolved Hide resolved
@Shell32-Natsu
Copy link
Contributor Author

As discussed offline we have decided to not support v1alpha2 version.

@Shell32-Natsu Shell32-Natsu merged commit ae8d961 into kptdev:main Jun 17, 2021
@Shell32-Natsu Shell32-Natsu deleted the update-crd-version branch June 17, 2021 17:51
@mengqiy mengqiy mentioned this pull request Jun 17, 2021
Merged
@Shell32-Natsu Shell32-Natsu mentioned this pull request Jun 17, 2021
Closed
Shell32-Natsu added a commit that referenced this pull request Jun 18, 2021
@Shell32-Natsu
Revert "Update crd version for Kptfile to v1 (#2248)"
62a4759 
This reverts commit ae8d961.
@Shell32-Natsu Shell32-Natsu mentioned this pull request Jun 18, 2021
Merged
Shell32-Natsu added a commit that referenced this pull request Jun 18, 2021
@Shell32-Natsu
Revert "Update crd version for Kptfile to v1 (#2248)" (#2278)
6e506b9 
This reverts commit ae8d961.
phanimarupaka added a commit that referenced this pull request Jun 19, 2021
@phanimarupaka
Revert "Revert "Update crd version for Kptfile to v1 (#2248)" (#2278)"
a27b7cc 
This reverts commit 6e506b9.
@phanimarupaka phanimarupaka mentioned this pull request Jun 19, 2021
Merged
phanimarupaka added a commit to phanimarupaka/kpt that referenced this pull request Jun 22, 2021
@phanimarupaka
Revert "Revert "Update crd version for Kptfile to v1 (kptdev#2248)" (…
bdfdaac 
…kptdev#2278)"

This reverts commit 6e506b9.
phanimarupaka added a commit to phanimarupaka/kpt that referenced this pull request Jun 22, 2021
@phanimarupaka
Revert "Revert "Update crd version for Kptfile to v1 (kptdev#2248)" (…
860601d 
…kptdev#2278)"

This reverts commit 6e506b9.
phanimarupaka added a commit that referenced this pull request Jun 22, 2021
@phanimarupaka
Update crds to v1 (#2294)
cbd342d 
* Revert "Revert "Update crd version for Kptfile to `v1` (#2248)" (#2278)"

This reverts commit 6e506b9.

* Update error message

* Suggested changes

* Uprev fix to v0.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortent mortent mortent approved these changes

@droot droot droot approved these changes

@frankfarzan frankfarzan frankfarzan approved these changes

@phanimarupaka phanimarupaka Awaiting requested review from phanimarupaka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shell32-Natsu @droot @mortent @frankfarzan