Fix support for local-config annotation #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfarzan
approved these changes
Jun 17, 2021
| @@ -127,6 +153,23 @@ func TestPathManifestReader_Read(t *testing.T) { | |||
| namespace: "test-namespace", | |||
| expectedErrMsg: "unknown resource types: Custom.custom.io", | |||
| }, | |||
| "local-config is filtered out": { | |||
There was a problem hiding this comment.
orthogonal to this: I'm pretty much convinced that declaring packages in Go like this is an anti-pattern. At some point, need to move away from this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds back the support for the local config annotation that was removed in error in an earlier PR. This also adds support for using
config.kubernetes.io/local-config: "false"to explicitly set a resource as not being local config. This means that even if the file with the resource is referenced from the hydration pipeline, it will be applied by kpt.Any other values than
"true"or"false"are also allowed and they will cause the resource to be considered local config. This is a little strange, but I don't think we should let kpt error out on other values.