Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added namespace provisioning example guide #3109

Merged
merged 1 commit into from
May 9, 2022
Merged

added namespace provisioning example guide #3109

merged 1 commit into from
May 9, 2022

Conversation

droot
Copy link
Contributor

@droot droot commented May 7, 2022 •
edited
Loading

This PR adds namespace provisioning example guide.

@bgrant0607
Copy link
Contributor

It looks like one of the yaml files was missing a line.

Title: I'd make it more informative and different from the other guide(s) we will likely have for the same scenario. "Namespace provisioning example via kpt CLI"?

@droot
Copy link
Contributor Author

droot commented May 9, 2022

It looks like one of the yaml files was missing a line.

That's a good catch.

Title: I'd make it more informative and different from the other guide(s) we will likely have for the same scenario. "Namespace provisioning example via kpt CLI"?

I like it. Went with your suggestion. Updated it.

@droot droot changed the title added kpt pkg the hard way guide added namespace provisioning example guide May 9, 2022
bgrant0607
bgrant0607 approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@bgrant0607 bgrant0607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yuwenma
yuwenma approved these changes May 9, 2022
View reviewed changes
site/guides/namespace-provisioning-example.md
@@ -0,0 +1,441 @@
# Namespace provisioning example via kpt CLI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest adding the link to the UI version guide, or simply call this "Namespace Provisioning Example"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am working with Chris to get UI guides published. I will take a second pass on reorganizing these once all guides are in.

Thanks for the suggestion.

@droot droot merged commit 3205565 into kptdev:main May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwenma yuwenma yuwenma approved these changes

@bgrant0607 bgrant0607 bgrant0607 approved these changes

@justinsb justinsb Awaiting requested review from justinsb

@mengqiy mengqiy Awaiting requested review from mengqiy

@martinmaly martinmaly Awaiting requested review from martinmaly

@mortent mortent Awaiting requested review from mortent

@natasha41575 natasha41575 Awaiting requested review from natasha41575

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@droot @bgrant0607 @yuwenma