fix updates on CLI side #3346
Merged
fix updates on CLI side #3346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natasha41575
requested review from
droot,
justinsb,
mengqiy,
mortent and
yuwenma
as code owners
natasha41575
force-pushed
the
totalfixingupdatesfix
branch
from
d30ab84
to
706a5e4
Compare
natasha41575
commented
Jul 7, 2022
natasha41575
force-pushed
the
totalfixingupdatesfix
branch
2 times, most recently
from
c402ea9
to
831886a
Compare
natasha41575
force-pushed
the
totalfixingupdatesfix
branch
from
831886a
to
2f84f82
Compare
|
LGTM; we'll likely want that update-clonetask-in-place logic when we merge #3336, but it looks like it's easy enough to add back so not an issue :-) |
Are we planning to only support reclone-and-replay in the CLI? Or will we have some way of supporting both that and merge updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the CLI compatible with the changes in the backend from #3338. (First 3 commits here are the same as in #3338 but for some reason still show up after rebasing.)
Related: #3329