Add missing license headers #3449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortent
requested review from
droot,
justinsb,
mengqiy,
natasha41575 and
yuwenma
as code owners
droot
reviewed
Aug 9, 2022
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
There was a problem hiding this comment.
hmm...So these manifests are actually sourced from cert-manager release bundle, so I am not sure if we want to use our license header on these. And the original manifests didn't have any license headers.
is it possible to skip certain directories from license-checks ?
There was a problem hiding this comment.
Yeah. I've updated the PR to exclude the three packages.
mortent
force-pushed
the
AddMisingLicenseHeaders
branch
from
90145fb
to
7fdd4d8
Compare
droot
approved these changes
Aug 9, 2022
chunglu-chou
pushed a commit
to chunglu-chou/kpt
that referenced
this pull request
Aug 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some files that are missing the license headers. This causes unexpected changes when running
make all. This PR excludes thecert-manager,ghostandingress-nginxpackages and updates the one remaining file that was missing the license.