Expose a Compute function for Config Connector status #3466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortent
requested review from
droot,
justinsb,
mengqiy,
natasha41575 and
yuwenma
as code owners
|
Looks good. If we think there might be more of these, we could consider defining + implementing an interface (for use with the unstructured form). But not a blocker. |
|
@justinsb Agree that there should be a specific interface for this. Just needed to unblock another effort so didn't want to start looking at that now. |
chunglu-chou
pushed a commit
to chunglu-chou/kpt
that referenced
this pull request
Aug 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes a function from the configconnector package that allows for computing the reconciliation status for a passed in Config Connector resource. This just restructures the existing code so that it is possible to use the basic code without requiring the full functionality of the StatusReader implementations.
The immediate use-case for this is to provide a way to handle status for Config Connector resources in the ResourceGroup controller: https://github.com/GoogleContainerTools/kpt-resource-group