Modify to use loader and inventory client interfaces in cli-utils #3483
Conversation
chunglu-chou
force-pushed
the
migrate
branch
2 times, most recently
from
5ef9973
to
844aa57
Compare
| @@ -45,13 +46,15 @@ func GetLiveCommand(ctx context.Context, _, version string) *cobra.Command { | |||
| } | |||
|
|
|||
| f := newFactory(liveCmd, version) | |||
| invFactory := live.NewClusterClientFactory() | |||
There was a problem hiding this comment.
I think we can just keep this inside the cmdstatus package?
There was a problem hiding this comment.
@morten Do you mean the NewClusterClientFactory function and the struct related to it or you are just saying this line could be placed inside the cmdstatus?
There was a problem hiding this comment.
I think the test utilizes the FakeClusterClient which is a different one, so the invFactory needs to be an input argument, otherwise the test will fail. But I think it's ok to move the implementation of the client factory into cmdstatus.
pkg/live/fake-loader.go
Outdated
| @@ -0,0 +1,61 @@ | |||
| package live | |||
There was a problem hiding this comment.
I think we can keep this one too in the cmdstatus package. It might be that we want to reuse it in the other kpt live commands, but we can move it if that happens.
chunglu-chou
force-pushed
the
migrate
branch
5 times, most recently
from
875da62
to
0df6f3b
Compare
chunglu-chou
requested review from
droot,
justinsb,
mengqiy,
natasha41575 and
yuwenma
as code owners
Remove the forked status command from cli-utils by implementing the loader and inventory client interfaces and utilize the command Runner code in cli-utils