Fix null pointer deref in diff if no Upstream #3549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `kpt pkg diff` without an upstream set panics because we attempt to dereference `kptFile.Upstream` without checking to see if it is nil. This commit adds a check and returns early if necessary.
Ralph7C2
requested review from
droot,
justinsb,
mengqiy,
mortent,
natasha41575 and
yuwenma
as code owners
natasha41575
reviewed
Sep 9, 2022
natasha41575
reviewed
Sep 9, 2022
Co-authored-by: Natasha Sarkar <natashasarkar@google.com>
Ralph7C2
force-pushed
the
rl/diff-npe
branch
from
8ee76c3
to
ef302f7
Compare
|
Awesome! Merging this in.. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
kpt pkg diffwithout an upstream set panics because we attemptto dereference
kptFile.Upstreamwithout checking to see if it is nil.This commit adds a check and returns early if necessary.