Refactor controller initialization logic #3566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinsb
requested review from
droot,
mengqiy,
mortent,
natasha41575 and
yuwenma
as code owners
mortent
approved these changes
Sep 21, 2022
By moving more logic to the SetupWithManager function, we can create something that is looking more like traditional discovery.
justinsb
force-pushed
the
refactor_controllers_to_be_injectable
branch
from
4dd9c48
to
c89dd35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By moving more logic to the SetupWithManager function, we can create
something that is looking more like traditional discovery.