Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delay for TestFunctionRepository to make sure the repo is cached #3831

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Add delay for TestFunctionRepository to make sure the repo is cached #3831

merged 1 commit into from
Feb 24, 2023

Conversation

mortent
Copy link
Contributor

@mortent mortent commented Feb 20, 2023

No description provided.

@mortent mortent marked this pull request as ready for review February 23, 2023 17:03
@mortent mortent requested a review from a team as a code owner February 23, 2023 17:03
@mortent mortent requested a review from droot February 23, 2023 17:03
@mortent
Copy link
Contributor Author

mortent commented Feb 23, 2023

@justinsb @droot This is a bit of an ugly hack, but I think it should help with the flaky tests until we can switch off using the aggregated apiserver for functions and use the CRD.

@droot
Copy link
Contributor

droot commented Feb 23, 2023

@justinsb @droot This is a bit of an ugly hack, but I think it should help with the flaky tests until we can switch off using the aggregated apiserver for functions and use the CRD.

Sounds good. Thanks for root causing it.

@yuwenma
Copy link
Contributor

yuwenma commented Feb 24, 2023

cc @ziyue-101
This PR will help on the healthcheck CI failure.

@mortent mortent merged commit 9c0c3fc into kptdev:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot droot approved these changes

@yuwenma yuwenma yuwenma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mortent @droot @yuwenma