Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollouts: add condition when external sync is created #3834

Merged

Conversation

ChristopherFry
Copy link
Contributor

This pull request updates the remote root sync to add the "ExternalSyncCreated" condition when an external sync is created on the target cluster. Beyond providing a higher-level status to the user, adding this condition allows us to improve the finalization logic to delete the external sync if one was created.

@ChristopherFry
Copy link
Contributor Author

Beyond providing a higher-level status to the user, adding this condition allows us to improve the finalization logic to delete the external sync if one was created.

Just to expand on this a little, this was the primary reason I am adding this condition. Today the remote root sync controller will throw an error and not allow a remote root sync to be deleted unless the logic is able to successfully the delete the external sync resource. This includes if the external sync resource was never created. This isn't necessarily as simple as adding a apierrors.IsNotFound check. The reason for this is the external sync resource may not be able to be created on the external cluster due to connectivity issues, and this issue will be seen in today's finalizer logic as well.

@ChristopherFry ChristopherFry merged commit 048ebec into kptdev:main Feb 22, 2023
@ChristopherFry ChristopherFry deleted the cfry/rollouts-root-sync-created branch February 22, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants