Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the api group name to be healthcheck.config.k8s.io #3848

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

ziyue-101
Copy link
Contributor

This PR renames the health check api group to be healthcheck.config.k8s.io, which is more OSS compared to the old one.

Fixes #3800

@ziyue-101 ziyue-101 requested a review from a team as a code owner February 23, 2023 22:11
@yuwenma
Copy link
Contributor

yuwenma commented Feb 23, 2023

I assume config.k8s.io is reserved for core k/k resources. Since the healthcheck is under kpt repo now, maybe you can consider using kpt.dev, like config.healthcheck.kpt.dev? How do you plan to suggest HealthCheck to the kpt users?

CC @droot @mortent @justinsb for inputs

@ziyue-101
Copy link
Contributor Author

ziyue-101 commented Feb 23, 2023

The group is not reserved by kubernetes, at least from this doc. :-) https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.26/#-strong-api-groups-strong-

I am not sure about the convention of Kpt, do all the api group names must contain kpt.dev?
I am happy to change the group name to be more appropriate. waiting for advice;-)

@mortent
Copy link
Contributor

mortent commented Feb 23, 2023

We have used config.k8s.io in the past, but I think we prefer to use something under the kpt.dev domain.

@ziyue-101
Copy link
Contributor Author

Thanks for the context. Changed to config.healthcheck.kpt.dev.

Copy link
Contributor

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Thanks for the change.

@yuwenma yuwenma merged commit 1291cfb into kptdev:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename the health check API group to something more OSS.
3 participants