add unit tests for remoterootsync controller #3860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droot
reviewed
Mar 6, 2023
natasha41575
force-pushed
the
rollouts/rrstest
branch
from
0b97c22
to
f66cc12
Compare
natasha41575
force-pushed
the
rollouts/rrstest
branch
from
f66cc12
to
3724f73
Compare
droot
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses part of of #3856
The bulk of the business logic in the
RemoteRootSyncreconciler looks like is in thepatchRootSyncfunction, so this PR adds unit tests forpatchRootSyncusing a fake kubernetes dynamic client.A note on sequencing, this has some conflicts with #3857 and #3850. Whichever PRs are merged last should (a) address the conflicts and (b) should ensure that unit tests for supporting
RepoSyncare also added here.I plan to add unit tests for
Rolloutscontroller separately.