Fix the edit/copy of packagerevisions #3863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortent
changed the title
natasha41575
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds proper support for the Edit/Copy task, which provides a way for creating new revisions of a package based on another one without using the replay strategy. This is needed for any package revisions that were not created through Porch and therefore doesn't have a task list we can use for replay.
The
kpt alpha rpkg editcommand will automatically choose theedit/copystrategy if the source revision doesn't have a task list. It also adds a flag that allows users to force theedit/copystrategy rather than the replay strategy.It also updates the rules for the same origin policy to handle the edit task.