rollouts: add development docs and releasing notes #3873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natasha41575
requested review from
yuwenma,
droot and
ChristopherFry
and removed request for
yuwenma
natasha41575
commented
Mar 10, 2023
natasha41575
commented
Mar 10, 2023
natasha41575
force-pushed
the
rollouts/devguide
branch
from
322b314
to
b83e3ab
Compare
droot
approved these changes
Mar 11, 2023
|
Merging, test failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some docs for rollouts devs: dev setup, releasing notes, and how to run the controllers locally.
While writing this up, I found some gaps in the make targets and scripts and updated them here. Would appreciate if the reviewer can dogfood to make sure it is working properly :)
A note, I'm not familiar with all aspects of rollouts code so feedback on descriptions of each package is welcome.