rollouts: scripts and dev guide for running with kind #3888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natasha41575
force-pushed
the
rollouts/kind
branch
2 times, most recently
from
d375576
to
0f237a2
Compare
natasha41575
force-pushed
the
rollouts/kind
branch
from
0f237a2
to
36f1092
Compare
droot
requested changes
Mar 16, 2023
rollouts/Makefile
Outdated
| .PHONY: run-in-kind | ||
| run-in-kind: manifests kustomize ## Run the rollouts-controller-manager in a kind cluster named rollouts-management-cluster | ||
| kind delete cluster --name=rollouts-management-cluster | ||
| kind create cluster --name=rollouts-management-cluster |
There was a problem hiding this comment.
one suggestion: we should invoke these commands with a kubeconfig location to avoid manipulating the default kubectl context. And then use KUBECONFIG=/path/to/kubeconfig/mgmt-cluster kubectl ... format for all the commands.
And we can use a standard directory path say .tests/kube/ and also add that path to .gitignore.
There was a problem hiding this comment.
Changed this to use ~/.kube/admin-cluster because that's what we did in the guide for running the admin cluster with config-controller.
| verbs: | ||
| - get | ||
| - list | ||
| - watch |
There was a problem hiding this comment.
Thanks for adding this: I completely missed these.
natasha41575
force-pushed
the
rollouts/kind
branch
from
072d4a4
to
8ba3467
Compare
droot
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds make targets for developing rollouts with
Kind, and updates the dev guide to add instructions for development with kind.Fixes #3887