Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rollouts: add namespace flag to CLI commands #3890

Merged
merged 1 commit into from
Mar 21, 2023
Merged

rollouts: add namespace flag to CLI commands #3890

merged 1 commit into from
Mar 21, 2023

Conversation

natasha41575
Copy link
Contributor

@natasha41575 natasha41575 commented Mar 21, 2023 •
edited

Fixes #3814

Took a look at the kpt live code and used the same method of adding the namespace flag via k8scmdutil.Factory. This makes it so that the rollouts commands use the default value from kubeconfig and also supports -n or --namespace arg.

@natasha41575 natasha41575 requested a review from droot March 21, 2023 18:26
@natasha41575 natasha41575 requested a review from a team as a code owner March 21, 2023 18:26
droot
droot approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@droot droot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

@natasha41575 natasha41575 merged commit fd920eb into kptdev:main Mar 21, 2023
@natasha41575 natasha41575 deleted the rollouts/namespaceCLI branch March 21, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot droot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rollouts CLI commands should support namespace --namespace argument
2 participants
@natasha41575 @droot