Continued evolution of the package variant design #3910
Conversation
|
|
||
|  | ||
| Rules for generating a PackageVariant are associated with a list of targets | ||
| using a template. That template can have explicit values for various |
There was a problem hiding this comment.
I'm not sure about the use of the word template here. I was at first thinking it would be similar to the PodSpec template in a Deployment resource, but this is somewhat different. At first this seems more like an overlay.
There was a problem hiding this comment.
Let's see what you think once I publish this. It's a lot like that.
There was a problem hiding this comment.
Ok, take a look at the complete API as published, see what you think. I think template is appropriate.
|
Marking this ready for review. Still to do before we move from "Work In Progress" to "Approved":
|
|
I ended up pulling separate use case list out, I discuss a few examples throughout the rest of the design. We can add more later if needed to understand the purpose. |
|
I believe this is complete now, and ready for review. |
johnbelamaric
force-pushed
the
pvs-design
branch
from
1709ff2
to
6e2d40f
Compare
|
Rebased |
| - `Ready` is set to True if the last reconciliation successfully produced an | ||
| up-to-date Draft. | ||
|
|
||
| The PackageVariant resource will also contain a `DownstreamTargets` field, |
There was a problem hiding this comment.
@natasha41575 is this an accurate description?
There was a problem hiding this comment.
Yes, that is accurate.
|  | ||
|
|
||
| users. | ||
| [^pvsimpl]: This document describes PackageVariantSet `v1alpha2`, which has not |
There was a problem hiding this comment.
@mortent I think we should just go ahead an implement the machinery for conversion webhooks. I am assuming they would run in the controller binary. We're likely to need them in the future. The actual roundtrip conversions in this case are pretty easy to do (the proposed v1alpha2 API is a superset of the v1alpha1 functionality).
Fix go tag
This PR will add additional details, including more on PackageVariantSet.