-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PackageVariantSet v1alpha2 #3930
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
ce198a7
Add the PackageVariantSet v1alpha2 API types
johnbelamaric 2d3471f
Generate the updated CRD
johnbelamaric ab46a70
Start work on the conversion methods
johnbelamaric d60c41d
Fix gofmt issue
johnbelamaric 0f51df9
Refactor and switch 'hub' type to v1alpha2
johnbelamaric c7d3bb4
gofmt fix
johnbelamaric 56a5a58
Implement more conversion and tests
johnbelamaric cc21ced
Updates for v2 api
johnbelamaric b62d089
Fix repositorySelector, ensurePV test
johnbelamaric 72fb285
Fix formatting
johnbelamaric 491c0f1
Fix status
johnbelamaric ad2756e
Add TestRenderPackageVariantSpec
johnbelamaric f506b98
Clean up the API a bit
johnbelamaric b80b074
Update validations for change API
johnbelamaric 455a02e
Implement all non-CEL template fields
johnbelamaric 95e87e4
Split into a few smaller files
johnbelamaric 540ea3c
Move render test to a separate file
johnbelamaric 9044bbe
Move validate tests to their own file
johnbelamaric 0ca5162
Update the design doc, add some API comments
johnbelamaric 00c685e
Initial CEL implementation
johnbelamaric bdf5aa1
More tests and some fixes
johnbelamaric 1e2c55e
go mod tidy
johnbelamaric 292ffa3
Stop serving v1alpha1 altogether
johnbelamaric b6ea267
Address review comments
johnbelamaric 2aeb6b6
Post rebase go mod tidy
johnbelamaric 9dfc65b
Fix panic due to not returning on error
johnbelamaric File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add
target
here too?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's described in the paragraph below, because it's contented varies based on the type of target. But I will add it here in a follow up PR.